-
Notifications
You must be signed in to change notification settings - Fork 13.1k
[IMPROVE] Add modal to close chats when tags/comments are not required #22225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rafaelblink
merged 23 commits into
omnichannel/general-moda-close-chats
from
generic_modal_close_chats
Jun 4, 2021
Merged
[IMPROVE] Add modal to close chats when tags/comments are not required #22225
rafaelblink
merged 23 commits into
omnichannel/general-moda-close-chats
from
generic_modal_close_chats
Jun 4, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generic_modal_close_chats
…generic_modal_close_chats
This reverts commit 2c581a2.
renatobecker
added a commit
that referenced
this pull request
Jun 5, 2021
…ed (#22245) * [IMPROVE] Add modal to close chats when tags/comments are not required (#22225) * [IMPROVE] Add modal to close chats when tags/comments are not required * department from subscribe correctly * fix departmentId and department from subscription. * undo sub departmentId change * undo sub departmentId change * fix room type * fix RoomHeader props type * Tags required with asterisk as all default labels of RC. * get deparment from subscription or room. * normalizing subscription and room into useOmnichannelRoom * Get room from useOmnichannelRoom into omnichannel header. * trying to skip build fail * Revert "trying to skip build fail" This reverts commit 2c581a2. Co-authored-by: Martin <[email protected]> Co-authored-by: pierre-lehnen-rc <[email protected]> Co-authored-by: Renato Becker <[email protected]> Co-authored-by: Rafael Ferreira <[email protected]> Co-authored-by: Tiago Evangelista Pinto <[email protected]> * Remove subscription interface from output. * remove cache from CI install * Revert "remove cache from CI install" This reverts commit f72ac44. Co-authored-by: Martin <[email protected]> Co-authored-by: pierre-lehnen-rc <[email protected]> Co-authored-by: Renato Becker <[email protected]> Co-authored-by: Rafael Ferreira <[email protected]> Co-authored-by: Tiago Evangelista Pinto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
When neither tags or comments are required to close a livechat, show this modal instead:

Issue(s)
Reiteration of #21468