Skip to content

Conversation

@rafaelblink
Copy link
Contributor

@rafaelblink rafaelblink commented Jun 3, 2021

Proposed changes (including videos or screenshots)

When neither tags or comments are required to close a livechat, show this modal instead:
Screen Shot 2021-05-20 at 7 33 19 PM

Issue(s)

Reiteration of #21468

@rafaelblink rafaelblink marked this pull request as ready for review June 3, 2021 01:40
@rafaelblink rafaelblink closed this Jun 4, 2021
@rafaelblink rafaelblink reopened this Jun 4, 2021
@rafaelblink rafaelblink closed this Jun 4, 2021
@rafaelblink rafaelblink reopened this Jun 4, 2021
@rafaelblink rafaelblink closed this Jun 4, 2021
@rafaelblink rafaelblink reopened this Jun 4, 2021
@rafaelblink rafaelblink changed the base branch from develop to omnichannel/general-moda-close-chats June 4, 2021 17:21
@rafaelblink rafaelblink merged commit c0918f7 into omnichannel/general-moda-close-chats Jun 4, 2021
@rafaelblink rafaelblink deleted the generic_modal_close_chats branch June 4, 2021 17:22
renatobecker added a commit that referenced this pull request Jun 5, 2021
…ed (#22245)

* [IMPROVE] Add modal to close chats when tags/comments are not required (#22225)

* [IMPROVE] Add modal to close chats when tags/comments are not required

* department from subscribe correctly

* fix departmentId and department from subscription.

* undo sub departmentId change

* undo sub departmentId change

* fix room type

* fix RoomHeader props type

* Tags required with asterisk as all default labels of RC.

* get deparment from subscription or room.

* normalizing subscription and room into useOmnichannelRoom

* Get room from useOmnichannelRoom into omnichannel header.

* trying to skip build fail

* Revert "trying to skip build fail"

This reverts commit 2c581a2.

Co-authored-by: Martin <[email protected]>
Co-authored-by: pierre-lehnen-rc <[email protected]>
Co-authored-by: Renato Becker <[email protected]>
Co-authored-by: Rafael Ferreira <[email protected]>
Co-authored-by: Tiago Evangelista Pinto <[email protected]>

* Remove subscription interface from output.

* remove cache from CI install

* Revert "remove cache from CI install"

This reverts commit f72ac44.

Co-authored-by: Martin <[email protected]>
Co-authored-by: pierre-lehnen-rc <[email protected]>
Co-authored-by: Renato Becker <[email protected]>
Co-authored-by: Rafael Ferreira <[email protected]>
Co-authored-by: Tiago Evangelista Pinto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants